Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dragarea again #7251

Merged
merged 5 commits into from
Aug 1, 2022
Merged

Add dragarea again #7251

merged 5 commits into from
Aug 1, 2022

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Jul 8, 2022 •
edited
Loading

Description

See #7080

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Jul 8, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@lookacat lookacat marked this pull request as ready for review July 11, 2022 08:23
@lookacat lookacat changed the title Add dragzone again Add dragarea again Jul 11, 2022
kulmann
kulmann suggested changes Jul 18, 2022
View reviewed changes
packages/web-app-files/src/App.vue Outdated Show resolved Hide resolved
changelog/unreleased/bugfix-add-droparea-again Outdated Show resolved Hide resolved
@kulmann kulmann mentioned this pull request Jul 20, 2022
Closed
@lookacat lookacat requested a review from kulmann August 1, 2022 10:17
kulmann
kulmann suggested changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add the dragarea to the public drop view in the files app.

packages/web-app-files/src/App.vue Outdated Show resolved Hide resolved
packages/web-app-files/src/App.vue Outdated Show resolved Hide resolved
@ownclouders
Copy link
Contributor

Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/27237/68/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicBasic-publicLinkCreate_feature-L117.png

webUISharingPublicBasic-publicLinkCreate_feature-L117.png

webUISharingPublicBasic-publicLinkCreate_feature-L135.png

webUISharingPublicBasic-publicLinkCreate_feature-L135.png

webUISharingPublicBasic-publicLinkCreate_feature-L99.png

webUISharingPublicBasic-publicLinkCreate_feature-L99.png

webUISharingPublicBasic-publicLinkEdit_feature-L138.png

webUISharingPublicBasic-publicLinkEdit_feature-L138.png

webUISharingPublicBasic-publicLinkEdit_feature-L164.png

webUISharingPublicBasic-publicLinkEdit_feature-L164.png

webUISharingPublicBasic-publicLinkEdit_feature-L63.png

webUISharingPublicBasic-publicLinkEdit_feature-L63.png

webUISharingPublicBasic-publicLinkEdit_feature-L77.png

webUISharingPublicBasic-publicLinkEdit_feature-L77.png

webUISharingPublicBasic-publicLinkEdit_feature-L91.png

webUISharingPublicBasic-publicLinkEdit_feature-L91.png

webUISharingPublicExpire-shareByPublicLinkExpiringLinks_feature-L11.png

webUISharingPublicExpire-shareByPublicLinkExpiringLinks_feature-L11.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

kulmann
kulmann approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 😍

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 1, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

20.0% 20.0% Coverage
0.0% 0.0% Duplication

@kulmann kulmann merged commit f415b04 into master Aug 1, 2022
@delete-merged-branch delete-merged-branch bot deleted the bugfix-dropzone branch August 1, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dropping a file does not show "dropzone"
3 participants
@lookacat @ownclouders @kulmann